-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add playwright check examples [kit-2234] #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add playwright check examples [kit-2234] #1156
Conversation
|
@sorccu this change 2858a8f fixed the create-cli issue from #1097 (comment) |
* improve ts advanded example * remove techniches example that fails consistently * update boilerplate TS template example * tweak advanced JS example * tweak readme and homepage spec * * JS simple example * Clarify deploy names to know which suites examples are used more JS vs TS * Align readmes * Include dependencies install step and clarify playwright test usage --------- Co-authored-by: Maxi Gimenez <[email protected]>
…y-cli-boilerplate-projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a blocker
| "author": "", | ||
| "license": "ISC", | ||
| "devDependencies": { | ||
| "@playwright/test": "^1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "@playwright/test": "^1", | |
| "@playwright/test": "1.54.1", |
For consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "author": "", | ||
| "license": "ISC", | ||
| "devDependencies": { | ||
| "@playwright/test": "^1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "@playwright/test": "^1", | |
| "@playwright/test": "1.54.1", |
| "license": "ISC", | ||
| "devDependencies": { | ||
| "checkly": "latest" | ||
| "@playwright/test": "^1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "@playwright/test": "^1", | |
| "@playwright/test": "1.54.1", |
Affected Components
Notes for the Reviewer
Add Playwright checks examples