Skip to content

Conversation

@maxigimenez
Copy link
Member

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Add Playwright checks examples

@maxigimenez maxigimenez marked this pull request as ready for review October 7, 2025 08:20
@maxigimenez
Copy link
Member Author

@sorccu this change 2858a8f fixed the create-cli issue from #1097 (comment)

maxigimenez and others added 6 commits October 9, 2025 09:21
* improve ts advanded example

* remove techniches example that fails consistently

* update boilerplate TS template example

* tweak advanced JS example

* tweak readme and homepage spec

* * JS simple example
* Clarify deploy names to know which suites examples are used more JS vs TS
* Align readmes
* Include dependencies install step and clarify playwright test usage

---------

Co-authored-by: Maxi Gimenez <[email protected]>
@maxigimenez maxigimenez requested a review from sorccu October 10, 2025 13:17
Copy link
Contributor

@MariadeAnton MariadeAnton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@ferrandiaz ferrandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker

"author": "",
"license": "ISC",
"devDependencies": {
"@playwright/test": "^1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@playwright/test": "^1",
"@playwright/test": "1.54.1",

For consistency

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"author": "",
"license": "ISC",
"devDependencies": {
"@playwright/test": "^1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@playwright/test": "^1",
"@playwright/test": "1.54.1",

"license": "ISC",
"devDependencies": {
"checkly": "latest"
"@playwright/test": "^1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@playwright/test": "^1",
"@playwright/test": "1.54.1",

@maxigimenez maxigimenez merged commit ef620b8 into main Oct 13, 2025
3 checks passed
@maxigimenez maxigimenez deleted the maxi/kit-2234-add-playwright-check-to-checkly-cli-boilerplate-projects branch October 13, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants